- Suisse
- https://github.com/LordBaryhobal
- Joined on
2023-02-15 -
-
Hey 👋, this looks pretty good, thanks for contributing ! I would just try to simplify the drawing process, since they are basically rectangles (see following comments)
I'll also add examples…
They don't seem too hard to add I might have a go at it but I can't promise a deadline You can take a look at how other logic gates are implemented in the time being
It's okay for me to modify the schema internally
It is somehow already the case in structure.load for example, where some properties are extracted and formatted from the input data
That is a great idea ! And yes I am open to PRs 👍 It's definitely something achievable, but it does indeed have some implication since - as you've mentioned - many elements are placed…
Done ✅ Waiting to be merged in Universe https://git.kb28.ch/HEL/rivet-typst/releases/tag/v0.3.0
3e74ad15ee
Merge pull request 'v0.3.0: updates, left-to-right bits and "Loading" manual section' (#7) from dev into main
422681ba6e
Merge pull request 'Left to right bits + Loading manual section' (#6) from feat/left-to-right-bits-1 into dev
I was waiting to see if anything would come up but since there wasn't, I'll make a release ASAP