FIX kMaxGearSize value
This commit is contained in:
		| @@ -22,5 +22,5 @@ repos: | |||||||
|       - id: cppcheck |       - id: cppcheck | ||||||
|         name: cppcheck |         name: cppcheck | ||||||
|         require_serial: true |         require_serial: true | ||||||
|         entry: cppcheck --enable=all --suppress=missingInclude --suppress=missingIncludeSystem --inline-suppr -i mbed-os --std=c++14 --error-exitcode=1 |         entry: cppcheck --enable=all --suppress=missingInclude --suppress=missingIncludeSystem --suppress=unusedStructMember --inline-suppr -i mbed-os --std=c++14 --error-exitcode=1 | ||||||
|         language: system |         language: system | ||||||
|   | |||||||
| @@ -36,7 +36,7 @@ static constexpr uint8_t kMaxGear = 9; | |||||||
| // smallest gear (= 1) corresponds to a gear size of 20 | // smallest gear (= 1) corresponds to a gear size of 20 | ||||||
| // when the gear increases, the gear size descreases | // when the gear increases, the gear size descreases | ||||||
| static constexpr uint8_t kMaxGearSize = 20; | static constexpr uint8_t kMaxGearSize = 20; | ||||||
| static constexpr uint8_t kMinGearSize = kMaxGearSize - kMinGear; | static constexpr uint8_t kMinGearSize = kMaxGearSize - kMaxGear; | ||||||
|  |  | ||||||
| // pedal related constants | // pedal related constants | ||||||
| // When compiling and linking with gcc, we get a link error when using static | // When compiling and linking with gcc, we get a link error when using static | ||||||
|   | |||||||
| @@ -80,7 +80,7 @@ class Speedometer { | |||||||
|     float _currentSpeed = 0.0f; |     float _currentSpeed = 0.0f; | ||||||
|     Mutex _totalDistanceMutex; |     Mutex _totalDistanceMutex; | ||||||
|     float _totalDistance = 0.0f; |     float _totalDistance = 0.0f; | ||||||
|     uint8_t _gearSize    = bike_computer::kMinGearSize; |     uint8_t _gearSize    = bike_computer::kMaxGearSize; | ||||||
|  |  | ||||||
| #if defined(MBED_TEST_MODE) | #if defined(MBED_TEST_MODE) | ||||||
|     mbed::Callback<void()> _cb; |     mbed::Callback<void()> _cb; | ||||||
|   | |||||||
| @@ -138,7 +138,7 @@ class BikeSystem { | |||||||
|     ////////////////////////////////////////////////////////////// |     ////////////////////////////////////////////////////////////// | ||||||
|     // shared resources between the main thread and the isr thread |     // shared resources between the main thread and the isr thread | ||||||
|     uint8_t _currentGear     = bike_computer::kMinGear; |     uint8_t _currentGear     = bike_computer::kMinGear; | ||||||
|     uint8_t _currentGearSize = bike_computer::kMinGearSize; |     uint8_t _currentGearSize = bike_computer::kMaxGearSize; | ||||||
|     ////////////////////////////////////////////////////////////// |     ////////////////////////////////////////////////////////////// | ||||||
|  |  | ||||||
|     // data member that represents the device for manipulating the pedal rotation |     // data member that represents the device for manipulating the pedal rotation | ||||||
|   | |||||||
| @@ -80,7 +80,7 @@ class BikeSystem { | |||||||
|     // data member that represents the device for manipulating the gear |     // data member that represents the device for manipulating the gear | ||||||
|     GearDevice _gearDevice; |     GearDevice _gearDevice; | ||||||
|     uint8_t _currentGear     = bike_computer::kMinGear; |     uint8_t _currentGear     = bike_computer::kMinGear; | ||||||
|     uint8_t _currentGearSize = bike_computer::kMinGearSize; |     uint8_t _currentGearSize = bike_computer::kMaxGearSize; | ||||||
|     // data member that represents the device for manipulating the pedal rotation |     // data member that represents the device for manipulating the pedal rotation | ||||||
|     // speed/time |     // speed/time | ||||||
|     PedalDevice _pedalDevice; |     PedalDevice _pedalDevice; | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user