From cbf0f2852ebf36f7434751ad916516228f79c643 Mon Sep 17 00:00:00 2001
From: LordBaryhobal <lordbaryhobal@gmail.com>
Date: Mon, 18 May 2026 11:01:39 +0200
Subject: [PATCH] feat(parser): add AnnotationStmt and ConstraintExpr

---
 core/ast/annotations.py | 30 ++++++++++++++++-
 parser/annotations.py   | 72 ++++++++++++++++++++++++++++-------------
 2 files changed, 78 insertions(+), 24 deletions(-)

diff --git a/core/ast/annotations.py b/core/ast/annotations.py
index 78a7ce6..c5dce93 100644
--- a/core/ast/annotations.py
+++ b/core/ast/annotations.py
@@ -9,6 +9,25 @@ from lexer.token import Token
 T = TypeVar("T")
 
 
+@dataclass(frozen=True)
+class Stmt(ABC):
+    @abstractmethod
+    def accept(self, visitor: Visitor[T]) -> T: ...
+
+    class Visitor(ABC, Generic[T]):
+        @abstractmethod
+        def visit_annotation_stmt(self, stmt: AnnotationStmt) -> T: ...
+
+
+@dataclass(frozen=True)
+class AnnotationStmt(Stmt):
+    name: Token
+    schema: Optional[SchemaExpr]
+
+    def accept(self, visitor: Stmt.Visitor[T]) -> T:
+        return visitor.visit_annotation_stmt(self)
+
+
 @dataclass(frozen=True)
 class Expr(ABC):
     @abstractmethod
@@ -17,6 +36,9 @@ class Expr(ABC):
     class Visitor(ABC, Generic[T]):
         @abstractmethod
         def visit_type_expr(self, expr: TypeExpr) -> T: ...
+        
+        @abstractmethod
+        def visit_constraint_expr(self, expr: ConstraintExpr) -> T: ...
 
         @abstractmethod
         def visit_schema_expr(self, expr: SchemaExpr) -> T: ...
@@ -28,12 +50,18 @@ class Expr(ABC):
 @dataclass(frozen=True)
 class TypeExpr(Expr):
     name: Token
-    schema: Optional[SchemaExpr]
+    constraints: list[ConstraintExpr]
 
     def accept(self, visitor: Expr.Visitor[T]) -> T:
         return visitor.visit_type_expr(self)
 
 
+@dataclass(frozen=True)
+class ConstraintExpr(Expr):
+    def accept(self, visitor: Expr.Visitor[T]) -> T:
+        return visitor.visit_constraint_expr(self)
+
+
 @dataclass(frozen=True)
 class SchemaExpr(Expr):
     left: Token
diff --git a/parser/annotations.py b/parser/annotations.py
index dcd3a32..e90cf43 100644
--- a/parser/annotations.py
+++ b/parser/annotations.py
@@ -1,6 +1,14 @@
 from typing import Optional
 
-from core.ast.annotations import Expr, SchemaElementExpr, SchemaExpr, TypeExpr
+from core.ast.annotations import (
+    AnnotationStmt,
+    ConstraintExpr,
+    Expr,
+    SchemaElementExpr,
+    SchemaExpr,
+    Stmt,
+    TypeExpr,
+)
 from lexer.token import Token, TokenType
 from parser.base import Parser
 from parser.errors import ParsingError
@@ -11,11 +19,15 @@ class AnnotationParser(Parser):
 
     SYNC_BOUNDARY: set[TokenType] = set()
 
-    def parse(self) -> Optional[Expr]:
-        expression: Optional[Expr] = self.annotation()
+    def parse(self) -> Optional[Stmt]:
+        stmt: Optional[Stmt] = None
+        try:
+            stmt = self.annotation()
+        except ParsingError:
+            self.synchronize()
         if not self.is_at_end():
             self.error(self.peek(), "Extra tokens")
-        return expression
+        return stmt
 
     def synchronize(self):
         """Skip tokens until a synchronization boundary is found
@@ -29,33 +41,47 @@ class AnnotationParser(Parser):
                 return
             self.advance()
 
-    def annotation(self) -> Optional[Expr]:
-        """Try and parse an annotation
+    def annotation(self) -> AnnotationStmt:
+        """Parse an annotation
 
-        Any parsing error is caught and None is returned
+        An annotation is written as `Type` or `Type[Schema]`
 
         Returns:
-            Optional[Expr]: the parsed annotation expression, or None if a ParsingError was raised
+            AnnotationStmt: the parsed annotation statement
         """
-        try:
-            return self.type()
-        except ParsingError:
-            self.synchronize()
-            return None
 
-    def type(self) -> TypeExpr:
-        """Parse a type definition
-
-        `Type` or `Type[Schema]`
-
-        Returns:
-            TypeExpr: the parsed type expression
-        """
         name: Token = self.consume(TokenType.IDENTIFIER, "Expected type identifier")
         schema: Optional[SchemaExpr] = None
         if self.match(TokenType.LEFT_BRACKET):
             schema = self.schema()
-        return TypeExpr(name=name, schema=schema)
+        return AnnotationStmt(name=name, schema=schema)
+
+    def type_expr(self) -> TypeExpr:
+        """Parse a type expression
+
+        Returns:
+            TypeExpr: the parsed type expression
+        """
+        name: Token = self.consume(TokenType.IDENTIFIER, "Expected type name")
+        constraints: list[ConstraintExpr] = []
+
+        while not self.is_at_end() and self.match(TokenType.PLUS):
+            print(self.peek())
+            print(self.tokens)
+            self.consume(TokenType.LEFT_PAREN, "Expected '(' before type constraint")
+            constraints.append(self.constraint_expr())
+            self.consume(TokenType.RIGHT_PAREN, "Expected ')' after type constraint")
+
+        return TypeExpr(name=name, constraints=constraints)
+
+    def constraint_expr(self) -> ConstraintExpr:
+        """Parse a type constraint
+
+        Returns:
+            ConstraintExpr: the parsed type constraint expression
+        """
+        # TODO
+        return ConstraintExpr()
 
     def schema(self) -> SchemaExpr:
         """Parse a schema definition
@@ -96,5 +122,5 @@ class AnnotationParser(Parser):
             name = self.advance()
             self.advance()
         if not self.match(TokenType.UNDERSCORE):
-            type = self.type()
+            type = self.type_expr()
         return SchemaElementExpr(name=name, type=type)